Eas fix orphan stat repair #636

Merged
merged 1 commit into from Aug 20, 2013

2 participants

@engelsanchez

A customer had a good number of riak_kv_stat restarts due to problems in
folsom as of yet undetermined. The number of processes was observed to
balloon in size. The stat repair process was created every time a
riak_kv_stat process was restarted. riak_kv_stat monitored this process,
but this process did not monitor riak_kv_stat, so when that went away,
this process stayed around forever blocked waiting on its msg box.
This change ensures the process monitors riak_kv_stat so it goes down
with it.

@engelsanchez engelsanchez Fix orphan stat repair process
A customer had a good number of riak_kv_stat restarts due to problems in
folsom as of yet undetermined. The number of processes was observed to
balloon in size. The stat repair process was created every time a
riak_kv_stat process was restarted. riak_kv_stat monitored this process,
but this process did not monitor riak_kv_stat, so when that went away,
this process stayed around forever blocked waiting on its msg box.
This change ensures the process monitors riak_kv_stat so it goes down
with it.
ee37f56
@evanmcc

This looks good. Without the patch I can get processes to grown in an unbounded way using the code below, with it, I cannot.

[begin timer:sleep(100), exit(whereis(riak_kv_stat), kill) end || _ <- lists:seq(1,200)].

👍

@engelsanchez engelsanchez merged commit 847d049 into 1.4 Aug 20, 2013

1 check failed

Details default The Travis CI build failed
@engelsanchez engelsanchez deleted the eas-fix-orphan-stat-repair branch Aug 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment