leveldb fold hardening for 1.4 #641

merged 1 commit into from Aug 22, 2013


None yet
2 participants

evanmcc commented Aug 22, 2013

moved to 1.4 and adapted for changes there. Requires the same tests. Adding filtering to the index seemed like the minimal change to the code, but I can see the argument for handling it in the backend for separation-of-concerns reasons. If it bothers you, please let me know.


engelsanchez commented Aug 22, 2013

Code looks good to me: all paths related to decoding seem to be covered, including new riak_index functions introduced with 2i pagination. Manually tested that 2i operations, bucket listing, key listing and the 1.3.1 index reformat can all finish in the presence of decoding errors (which become warnings in the log)
👍 💃 ⛵️

evanmcc added a commit that referenced this pull request Aug 22, 2013

@evanmcc evanmcc merged commit 916c926 into 1.4 Aug 22, 2013

1 check failed

default The Travis CI build failed

@seancribbs seancribbs deleted the pevm-leveldb-fold-hardening-1.4 branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment