Fix timeout handling for key and bucket listing via HTTP #856

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
2 participants
Contributor

kellymclaughlin commented Feb 25, 2014

Commit 32060f0 changed error handling in
riak_kv_keys_fsm and riak_kv_buckets_fsm to return error tuples instead of
just the error reason term. This broke the error message expectations for
timeout messages in riak_kv_wm_keylist and riak_kv_wm_buckets. This change
updates the error handling in those modules to be consistent with the current
form sent by the fsm modules.

This can be tested using the verify_api_timeouts riak_test
module. Without this change the test and the associated keylisting
request hangs attempting to verify the timeout for keylisting request
works correctly. With this change the test works as expected and
passes.

@kellymclaughlin kellymclaughlin Fix timeout handling for key and bucket listing via HTTP
Commit 32060f0 changed error handling
in riak_kv_keys_fsm and riak_kv_buckets_fsm to return error tuples
instead of just the error reason term. This broke the error message
expectations for timeout messages in riak_kv_wm_keylist and
riak_kv_wm_buckets. This change updates the error handling in those
modules to be consistent with the current form sent by the fsm
modules.
fdfde16
Contributor

andrewjstone commented Feb 25, 2014

Code looks good. Running verify_api_timeouts now.

Contributor

andrewjstone commented Feb 25, 2014

Confirmed that verify_api_timeouts hangs on develop but passes with this fix.

👍

kellymclaughlin merged commit fdfde16 into develop Feb 25, 2014

1 check failed

default Build done.
Details

kellymclaughlin deleted the bugfix/http-keylisting-timeout-handling branch Feb 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment