Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

precommit/postcommit empty does not clear #32

Closed
seancribbs opened this Issue Feb 28, 2013 · 0 comments

Comments

Projects
None yet
2 participants

Because an empty list on a repeated field and not including it in the payload are equivalent, we need another field in the message to signify whether that field is present for commit hooks. Without the additional field, we either:

  1. are never able to clear the precommit or postcommit properties to the empty-list, or
  2. always clear the commit-hook list when excluded from the original payload

Neither behavior is desirable. This was discovered while developing basho/riak_test#228.

@seancribbs seancribbs added a commit that referenced this issue Feb 28, 2013

@seancribbs seancribbs Add another flag for the presence of each precommit and postcommit
properties. Fixes #32.

I wouldn't normally change a whole bunch of field numbers, but this has
not been finalized into a release. This resolves a problem found in
the bucket_props_roundtrip riak_test.
9b710a0

@seancribbs seancribbs closed this in a7dec49 Mar 1, 2013

@seancribbs seancribbs removed their assignment May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment