Skip to content
This repository

Protoc dependency free version for Python Package Index #36

Closed
martyanov opened this Issue · 3 comments

2 participants

Andrey Martyanov Sean Cribbs
Andrey Martyanov

I've created a repo https://github.com/martyanov/riak_pb_precompiled based on a PYPI riak_pb version 1.2.1 and removed unnecessary stuff to demonstrate what I mean.

I think protoc and build hooks are useful only during development.

Sean Cribbs
Collaborator

Would it be possible to convert that into some steps that would provide an sdist tarball that includes the precompiled proto files for pypi?

Andrey Martyanov

You already have the working machinery. I'm just proposing to split the package building into two separate steps:
1. Use proto_cmd.py as a separate executable, remove cmdclass from setup.py;
2. Build a tarball, we should remove MANIFEST.IN to exclude unnecessary protobuf sources and proto_cmd.py;
3. Edit Makefile.

I use the proposed repository to install riak-python-client on Heroku, because protoc installation really complicates the deployment.

Andrey Martyanov

I've just created pull request with a possible solution. Please see #37.

It's the easiest working solution, but may be it's better to refactor proto_cmd.py, now it looks like a dirty hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.