Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak_pb_messages.beam does not get built with a current rebar version [JIRA: RIAK-1555] #95

Closed
hanikesn opened this issue Jun 4, 2014 · 8 comments

Comments

@hanikesn
Copy link

hanikesn commented Jun 4, 2014

Try cloning the riak_pb repo two times. The first time build it with the included rebar binary, the second time build it with the rebar executable from https://raw.github.com/wiki/rebar/rebar/rebar.

The second time riak_pb_messages.beam does not get build, because the riak_pb_msgcodegen plugin is not used correctly.

This could also be an issue with rebar itself.

@kellymclaughlin kellymclaughlin added this to the 2.1 milestone Jun 13, 2014
@binarytemple
Copy link
Contributor

I'm also having problems building a test application getting a warning message:
WARN: Missing plugins: [riak_pb_msgcodegen]

In rebar.config, I even explicitly specified the riak_pb dependency. The original is there as well, I know that because I got a version mismatch (which I corrected)

%%-*- mode: erlang -*-

{erl_opts, [
            {src_dirs, ["./src"]},
            {parse_transform, lager_transform}
           ]}.

{deps, [
        {lager,  "2.0.*", {git, "git://github.com/basho/lager.git", "master"}},
        {riakc, ".*", {git, "git://github.com/basho/riak-erlang-client", "master" }},
        {riak_pb, ".*", {git, "git://github.com/basho/riak_pb", {tag,"2.0.0.16"}  }}
]}.
{plugins, [riak_pb_msgcodegen]}.
{require_otp_vsn, "R1[456]"}.

@HashNuke
Copy link
Contributor

HashNuke commented Sep 5, 2014

This issue needs some love.

riak_pb comes with an old pre-release version of rebar. Something must have changed about the way rebar handles plugins (the API for which is undocumented and is still in flux according to this issue https://github.com/rebar/rebar/issues/104).

@HashNuke
Copy link
Contributor

HashNuke commented Sep 5, 2014

@hanikesn @binarytemple @kellymclaughlin

I fixed this in a pull request #101.

@DeadZen
Copy link

DeadZen commented Feb 19, 2015

+1 get this thing merged in before it bit rots any further...

@Basho-JIRA Basho-JIRA changed the title riak_pb_messages.beam does not get built with a current rebar version riak_pb_messages.beam does not get built with a current rebar version [JIRA: RIAK-1555] Feb 19, 2015
@Basho-JIRA
Copy link

[~seancribbs] please review and assign according to what you find out.

_[posted via JIRA by Derek Somogyi]_

@DeadZen
Copy link

DeadZen commented Feb 26, 2015

w00t

@cmeiklejohn
Copy link
Contributor

I've merged these changes into #110 to have a resolved build. I suggest we merge #110 and close this PR.

@seancribbs
Copy link

This was resolved by #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants