PB Updates for HLL Datatypes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
feature-zl-hll_datatypes
branch
2 times, most recently
from
dd194ce
to
824b12b
Compare
7 tasks
zeeshanlakhani
force-pushed
the
feature-zl-hll_datatypes
branch
from
824b12b
to
7707d98
Compare
Merged
7 tasks
| /* We return an estimated cardinality of the Hyperloglog set | ||
| * on fetch. | ||
| */ | ||
| optional sint64 hll_value = 4; |
There was a problem hiding this comment.
why sint64? I thought hll cards were always positive
|
+1 from me. Nag nag about mixing formatting and functional changes. |
|
+1 |
zeeshanlakhani
force-pushed
the
feature-zl-hll_datatypes
branch
from
4e285c4
to
bfab43d
Compare
| @@ -22,7 +22,8 @@ | |||
| */ | |||
|
|
|||
| /* | |||
| ** Revision: 2.0 | |||
| %% TODO: Set for whichever release version we use | |||
| ** Revision: 2.3.0 | |||
There was a problem hiding this comment.
Should we modify this to 2.2.0?
There was a problem hiding this comment.
I left this question to @JeetKunDoug w/ the release time (we didn't know at the time)... so @nickelization, you're good to do that (and keep it as a separate commit) if Riak team is ok w/ it ;).
Ran this by Zeeshan, he said go ahead.
|
👍 84ec1f4 |
borshop
added a commit
that referenced
this pull request
Aug 16, 2016
PB Updates for HLL Datatypes Reviewed-by: nickelization
|
Build was successful, but Bors seems to be stuck for some reason. Going ahead and merging this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions?