Skip to content

fix for issue #5 - Add support for most bucket properties to PBC Interface (enhancement) #23

Closed
wants to merge 1 commit into from

3 participants

@aschepis

Add support for last_write_wins, backend, r, w, dw, rw, precommit, and postcommit bucket
properties when setting/getting bucket properties through the protobuf interface.

@aschepis

actually -- i just realized that this won't work for javascript precommit hooks.. going to reword the proto to have "fun" and "name" properties so both can be supported.

@aschepiswork aschepiswork fix for issue #5 - Add support for most bucket properties to PBC Inte…
…rface (enhancement)

Add support for last_write_wins, backend, r, w, dw, rw, precommit, and postcommit bucket
properties when setting/getting bucket properties through the protobuf interface.
42f285b
@aschepis

fixed that issue and rebased into single commit.

@seancribbs

@aschepis I like the goal in general, but we have internally considered going with a slightly different approach. I guess I should have laid out that idea publicly, shame on me!

@aschepis

how far off are the two approaches? perhaps i could refactor what i've done while i'm in the area.

@seancribbs

@aschepis The idea is that each application would define its own bucket properties extensions, and we would make the core message extensible. Obviously this will break backwards compatibility if not done carefully.

@aschepis

ok.. that's actually not that big a deal.. so does that mean that RpbBucketProps moves to riak.proto and defines a range for extensions and then riak_kv.proto extends it to add the new properties?

How did you envision that affecting the riak_pb_kv_codec.erl file?

@seancribbs

@aschepis TBD. A lot of this was still on the drawing board, naturally.

@aschepis

:) understood. Feel free to close this pull request or just loop me in and I can take care of it.

@seancribbs

Replaced by #30

@seancribbs seancribbs closed this Feb 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.