Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messages for exporter tool & list timeouts #41

Merged
merged 3 commits into from May 24, 2013
Merged

Add messages for exporter tool & list timeouts #41

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
298eb77
- add asis for puts
evanmcc Apr 18, 2013
53447a0
Merge branch 'master' into pevm-list-timeouts
evanmcc May 8, 2013
2e8e099
add the ability to specify streaming to bucket list messages.
evanmcc May 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/riak_kv.proto
View file
Open in desktop
Expand Up @@ -106,17 +106,24 @@ message RpbDelReq {


// Delete response - not defined, will return a RpbDelResp on success or RpbErrorResp on failure // Delete response - not defined, will return a RpbDelResp on success or RpbErrorResp on failure


// List buckets request - no message defined, just send RpbListBucketsReq // List buckets request
message RpbListBucketsReq {
optional uint32 timeout = 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a field here to indicate that we expect the response to stream, as this was not the case in previous API revisions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the pattern set by key listings, but you're right, for backwards compatibility we should have this and possibly modify the response. I'll take another look at pb_buckets code.

optional bool stream = 2;
}


// List buckets response // List buckets response - one or more of these packets will be sent
// the last one will have done set true (and may not have any buckets in it)
message RpbListBucketsResp { message RpbListBucketsResp {
repeated bytes buckets = 1; repeated bytes buckets = 1;
optional bool done = 2;
} }




// List keys in bucket request // List keys in bucket request
message RpbListKeysReq { message RpbListKeysReq {
required bytes bucket = 1; required bytes bucket = 1;
optional uint32 timeout = 2;
} }


// List keys in bucket response - one or more of these packets will be sent // List keys in bucket response - one or more of these packets will be sent
Expand Down