Remove need to have protoc available in Python source package. Closes #36 #42

Merged
merged 2 commits into from May 1, 2013

Projects

None yet

2 participants

@seancribbs

See also #37

@seancribbs seancribbs was assigned Apr 19, 2013
@engelsanchez engelsanchez was assigned May 1, 2013
@engelsanchez

To be able to run the python_compile and python_clean make targets, I had to tweak setup.py and remove this line:
-from proto_cmd import build_proto, clean_proto

I'm unable to run plain make due to Maven not liking me, but that's another story :(

@engelsanchez

Ok, I can now run make python_compile and make python_clean from a pristine virtual environment with protoc installed system-wide (failing if not global protoc is there). I'd say:

👍 💃 ⛵️

@seancribbs seancribbs merged commit 9fb4534 into master May 1, 2013

1 check passed

Details default The Travis build passed
@seancribbs seancribbs deleted the sdc-py-protoc branch May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment