Move eunit system tests to riak_test #62

Merged
merged 3 commits into from Feb 19, 2013

Conversation

Projects
None yet
3 participants
@beerriot
Contributor

beerriot commented Jan 7, 2013

The cluster startup and teardown in these eunit tests is rather fragile. The tests have been translated to riak_test, which is better at handling cluster configuration, in basho/riak_test#143. This PR exports a function needed by those tests, removes the duplicates here, reworks some non-system tests to simpler unit tests (in riak_pipe_fitting), and also removes the cluster setup and teardown code. Once basho/riak_test#143 is accepted, I suggest accepting this PR as well to reduce some of the fragility in our unit tests.

Bryan Fink added some commits Jan 7, 2013

Bryan Fink
remove tests that were migrated to riak_test
these tests were moved to riak_test as part of commit
a63c30993e93db8c9f3c2e912b5fcab238cdb635 in that repo,
in pull request riak_test#143
Bryan Fink
move validate_test_ from riak_pipe to riak_pipe_fitting
These tests all exercise riak_pipe_fitting, and don't need to startup a
cluster to do so. Since there are no more tests that need to startup a
cluster, remove that code as well.

@ghost ghost assigned beerriot Jan 7, 2013

@jonmeredith

This comment has been minimized.

Show comment
Hide comment
@jonmeredith

jonmeredith Jan 7, 2013

Contributor

/me cheers!

Contributor

jonmeredith commented Jan 7, 2013

/me cheers!

@ghost ghost assigned joedevivo Jan 8, 2013

@joedevivo

This comment has been minimized.

Show comment
Hide comment
@joedevivo

joedevivo Feb 19, 2013

Contributor

+1

Contributor

joedevivo commented Feb 19, 2013

+1

beerriot pushed a commit that referenced this pull request Feb 19, 2013

@beerriot beerriot merged commit 3e50c44 into master Feb 19, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment