Skip to content

Loading…

Move eunit system tests to riak_test #62

Merged
merged 3 commits into from

3 participants

@beerriot

The cluster startup and teardown in these eunit tests is rather fragile. The tests have been translated to riak_test, which is better at handling cluster configuration, in basho/riak_test#143. This PR exports a function needed by those tests, removes the duplicates here, reworks some non-system tests to simpler unit tests (in riak_pipe_fitting), and also removes the cluster setup and teardown code. Once basho/riak_test#143 is accepted, I suggest accepting this PR as well to reduce some of the fragility in our unit tests.

Bryan Fink added some commits
Bryan Fink export riak_pipe:zero_part/1 for use from riak_test 4709002
Bryan Fink remove tests that were migrated to riak_test
these tests were moved to riak_test as part of commit
a63c30993e93db8c9f3c2e912b5fcab238cdb635 in that repo,
in pull request riak_test#143
b72e4e0
Bryan Fink move validate_test_ from riak_pipe to riak_pipe_fitting
These tests all exercise riak_pipe_fitting, and don't need to startup a
cluster to do so. Since there are no more tests that need to startup a
cluster, remove that code as well.
3e50c44
@beerriot beerriot was assigned
@jonmeredith
Basho Technologies member

/me cheers!

@joedevivo joedevivo was assigned
@beerriot beerriot merged commit 3e50c44 into master

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 7, 2013
  1. remove tests that were migrated to riak_test

    Bryan Fink committed
    these tests were moved to riak_test as part of commit
    a63c30993e93db8c9f3c2e912b5fcab238cdb635 in that repo,
    in pull request riak_test#143
  2. move validate_test_ from riak_pipe to riak_pipe_fitting

    Bryan Fink committed
    These tests all exercise riak_pipe_fitting, and don't need to startup a
    cluster to do so. Since there are no more tests that need to startup a
    cluster, remove that code as well.
Something went wrong with that request. Please try again.