assume handoff if vnode exits 'normal' during queue requeuest #64

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@beerriot
Contributor

The pipe_verify_handoff_blocking test in basho/riak_test#154 demonstrated
that the monitor used by riak_pipe_vnode:queue_work_send may fire while
handoff is taking place. This situation is further described in
#63.

This PR addresses the problem by first checking whether the Reason
for the vnode's exit was normal. If it was not normal, the
vnode_down error is returned as before. If it was normal, then it is
assumed that handoff happened, and the monitor is moved to the new
vnode, as indicated by riak_core_ring:next_owner/2.

This PR targets bwf-riak_test, because commits in that branch are needed to run the riak_test proof, but I wanted this PR to be clear about what it was.

Bryan Fink assume handoff if vnode exits 'normal' during queue requeuest
The pipe_verify_handoff_blocking test in riak_test PR 154 demonstrated
that the monitor used by riak_pipe_vnode:queue_work_send may fire while
handoff is taking place. This situation is further described in
riak_pipe issue 63.

This commit addresses the problem by first checking whether the Reason
for the vnode's exit was 'normal'. If it was not 'normal', the
vnode_down error is returned as before. If it was 'normal', then it is
assumed that handoff happened, and the monitor is moved to the new
vnode, as indicated by riak_core_ring:next_owner/2.
fd72f55
@beerriot beerriot closed this Feb 19, 2013
@russelldb
Contributor

re-opened as #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment