Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PB service deregistration on stop. #116

Merged
merged 2 commits into from Aug 22, 2012
Merged

Conversation

seancribbs
Copy link
Contributor

This helps address the lingering service registration problem in #353 while maintaining correctness. Requires merge of basho/riak_api#10.

@ghost ghost assigned seancribbs Jun 24, 2012
@ghost ghost assigned joedevivo and seancribbs Aug 9, 2012
@seancribbs
Copy link
Contributor Author

basho/riak_api#4 has been closed because its implementation is race-prone. I will redo, but the registration/deregistration API should probably stay the same.

@travisbot
Copy link

This pull request passes (merged 32a1e7d into 7420a3a).

@joedevivo
Copy link
Contributor

+1

seancribbs added a commit that referenced this pull request Aug 22, 2012
Add PB service deregistration on stop.
@seancribbs seancribbs merged commit e577571 into master Aug 22, 2012
@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants