Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Use a sliding one minute window not a EWMA meter #121

Merged
merged 1 commit into from about 2 years ago

2 participants

Russell Brown Ryan Zezeski
Russell Brown
Collaborator

Depends on boundary/folsom#27

Ryan Zezeski
Collaborator

+1 to merge

Russell Brown russelldb merged commit 4c719e3 into from
Russell Brown russelldb closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jul 02, 2012
Russell Brown russelldb Use a sliding one minute window not a EWMA meter 348425f
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 10 additions and 10 deletions. Show diff stats Hide diff stats

  1. +10 10 src/riak_search_stat.erl
20 src/riak_search_stat.erl
@@ -91,7 +91,7 @@ update1(index_begin) ->
91 91 folsom_metrics:notify_existing_metric({?APP, index_pending}, {inc, 1}, counter);
92 92 update1({index_end, Time}) ->
93 93 folsom_metrics:notify_existing_metric({?APP, index_latency}, Time, histogram),
94   - folsom_metrics:notify_existing_metric({?APP, index_throughput}, 1, meter),
  94 + folsom_metrics:notify_existing_metric({?APP, index_throughput}, 1, spiral),
95 95 folsom_metrics:notify_existing_metric({?APP, index_pending}, {dec, 1}, counter);
96 96 update1({index_entries, N}) ->
97 97 folsom_metrics:notify_existing_metric({?APP, index_entries}, N, histogram);
@@ -99,19 +99,19 @@ update1(search_begin) ->
99 99 folsom_metrics:notify_existing_metric({?APP, search_pending}, {inc, 1}, counter);
100 100 update1({search_end, Time}) ->
101 101 folsom_metrics:notify_existing_metric({?APP, search_latency}, Time, histogram),
102   - folsom_metrics:notify_existing_metric({?APP, search_throughput}, 1, meter),
  102 + folsom_metrics:notify_existing_metric({?APP, search_throughput}, 1, spiral),
103 103 folsom_metrics:notify_existing_metric({?APP, search_pending}, {dec, 1}, counter);
104 104 update1(search_fold_begin) ->
105 105 folsom_metrics:notify_existing_metric({?APP, search_fold_pending}, {inc, 1}, counter);
106 106 update1({search_fold_end, Time}) ->
107 107 folsom_metrics:notify_existing_metric({?APP, search_fold_latency}, Time, histogram),
108   - folsom_metrics:notify_existing_metric({?APP, search_fold_throughput}, 1, meter),
  108 + folsom_metrics:notify_existing_metric({?APP, search_fold_throughput}, 1, spiral),
109 109 folsom_metrics:notify_existing_metric({?APP, search_fold_pending}, {dec, 1}, counter);
110 110 update1(search_doc_begin) ->
111 111 folsom_metrics:notify_existing_metric({?APP, search_doc_pending}, {inc, 1}, counter);
112 112 update1({search_doc_end, Time}) ->
113 113 folsom_metrics:notify_existing_metric({?APP, search_doc_latency}, Time, histogram),
114   - folsom_metrics:notify_existing_metric({?APP, search_doc_throughput}, 1, meter),
  114 + folsom_metrics:notify_existing_metric({?APP, search_doc_throughput}, 1, spiral),
115 115 folsom_metrics:notify_existing_metric({?APP, search_doc_pending}, {dec, 1}, counter).
116 116
117 117
@@ -128,24 +128,24 @@ stats() ->
128 128 {index_entries, histogram},
129 129 {index_latency, histogram},
130 130 {index_pending, counter},
131   - {index_throughput, meter},
  131 + {index_throughput, spiral},
132 132 {search_pending, counter},
133 133 {search_latency, histogram},
134   - {search_throughput, meter},
  134 + {search_throughput, spiral},
135 135 {search_fold_pending, counter},
136 136 {search_fold_latency, histogram},
137   - {search_fold_throughput, meter},
  137 + {search_fold_throughput, spiral},
138 138 {search_doc_pending, counter},
139 139 {search_doc_latency, histogram},
140   - {search_doc_throughput, meter}
  140 + {search_doc_throughput, spiral}
141 141 ].
142 142
143 143 register_stat(Name, histogram) ->
144 144 %% get the global default histo type
145 145 {SampleType, SampleArgs} = get_sample_type(Name),
146 146 folsom_metrics:new_histogram({?APP, Name}, SampleType, SampleArgs);
147   -register_stat(Name, meter) ->
148   - folsom_metrics:new_meter({?APP, Name});
  147 +register_stat(Name, spiral) ->
  148 + folsom_metrics:new_spiral({?APP, Name});
149 149 register_stat(Name, counter) ->
150 150 folsom_metrics:new_counter({?APP, Name}).
151 151

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.