Az482 fix intersection mem leak #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
az482 In the select_fun for the intersection_op (i.e. AND) it would stop once one of it's iterators had been exhausted but would leave the other one as is, messages and all. So in the case where one side is empty and other side has a bunch of results (or this query is run a lot, memory usage = result size * # of queries) the results just sit on a process that waits indefinitely for something to pull the results off it's mailbox. The reason this doesn't occur if you use a PB conn for each transaction is because he PB conn is the parent of these processes and they are all linked. If it dies they all die. The solution is to make sure all iterators are exhausted.
|
Looks good. Verified using https://github.com/gordyt/riaksearch-test. |
rzezeski
added a commit
that referenced
this pull request
Jul 1, 2011
Az482 fix intersection mem leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az482
In the select_fun for the intersection_op (i.e. AND) it would stop
once one of it's iterators had been exhausted but would leave the
other one as is, messages and all. So in the case where one side is
empty and other side has a bunch of results (or this query is run a
lot, memory usage = result size * # of queries) the results just sit
on a process that waits indefinitely for something to pull the results
off it's mailbox. The reason this doesn't occur if you use a PB conn
for each transaction is because he PB conn is the parent of these
processes and they are all linked. If it dies they all die.
The solution is to make sure all iterators are exhausted.