Test new MR Search Switch and "index" spec #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riak attempts to choose the correct search system (riak_search or
yokozuna) to provide MapReduce inputs when {search, Bucket, Query} is
specified. The `mapred_search_switch` test makes sure that the expected
system is chosen, given the cluster's configuration (whether riak_search
and yokozuna are each enabled, and whether the choice of which to use
has been set explicitly).
since they don't map 1:1, make sure the translation takes place also add a wait for the index to become available before writing data for it
to make sure that riak_search unmaps and that yokozuna doesn't remap
it will be translating the bucket search to an index search, but it should also be filtering that index search by the bucket name
This was referenced Sep 19, 2013
|
It might be a good idea to convert the MR requests to use the HTTP interface, so they have to go through JSON translation, instead of skirting by with erlang external format. |
if both riak_search and yokozuna are enabled, but the riak_kv:mapred_search appenv has not been set, default to riak_search
we have ripped out the earlier {index, Index} option to simplify things
yokozuna mapred_search no longer adds a bucket-name filter when mapred-searching a bucket, so don't test for it working here
The "bucket" is the "index". Chalk it up to poor naming make a long time ago. We're only human.
|
+1 to merge. |
rzezeski
added a commit
that referenced
this pull request
Sep 25, 2013
Test new MR Search Switch and "index" spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #373.
As of basho/riak_kv#664, Riak attempts to choose the correct system (riak_search or yokozuna) to provide MapReduce inputs when "search" is specified. The
mapred_search_switchtest makes sure that the expected system is chosen, given the cluster's configuration.As of basho/yokozuna#174, when YZ is chosen, the
Bucketin the traditional{search, Bucket, Query}form of search MR inputs will be translated to its associated index. The three extra commits in this PR that did not appear in #373 test that this is the case, and also that YZ filters results from other buckets stored in the same index.