Skip to content

Commit

Permalink
Fix a few mistakes.
Browse files Browse the repository at this point in the history
  • Loading branch information
Gregory Burd committed Dec 16, 2011
1 parent 9ee8a6c commit 2f9f9a0
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/riaknostic_check_ring_size.erl
Expand Up @@ -43,15 +43,15 @@ check() ->
Stats = riaknostic_node:stats(),
{ring_creation_size, RingSize} = lists:keyfind(ring_creation_size, 1, Stats),
{ring_num_partitions, NumPartitions} = lists:keyfind(ring_num_partitions, 1, Stats),
{ring_members, RingMembers} = lists:keyfind(ring_members, 1, Stats),
NumRingMembers = length(RingMembers),
VnodesPerNode = erlang:round(RingSize / NumRingMembers),
MinAcceptableVnodesPerNode = erlang:round(RingSize * 0.03),
MaxRecommendedVnodesPerNode = erlang:round(RingSize * 0.7),
% {ring_members, RingMembers} = lists:keyfind(ring_members, 1, Stats),
% NumRingMembers = length(RingMembers),
% VnodesPerNode = erlang:round(RingSize / NumRingMembers),
% MinAcceptableVnodesPerNode = erlang:round(RingSize * 0.03),
% MaxRecommendedVnodesPerNode = erlang:round(RingSize * 0.7),

lists:append([
[ {notice, {ring_size_unequal, RingSize, NumPartitions}} || RingSize /= NumPartitions ],
[ {critical, {ring_size_not_exp2, RingSize}} || (RingSize band -(bnot RingSize)) /= RingSize],
[ {critical, {ring_size_not_exp2, RingSize}} || (RingSize band -(bnot RingSize)) /= RingSize]
% [ {notice, {ring_size_too_small, RingSize, NumRingMembers}} || VnodesPerNode =< MinAcceptableVnodesPerNode ],
% [ {notice, {too_few_nodes_for_ring, RingSize, NumRingMembers}} || VnodesPerNode >= MaxRecommendedVnodesPerNode ]
]).
Expand All @@ -63,7 +63,7 @@ format({ring_size_unequal, S, P}) ->

format({ring_size_not_exp2, S}) ->
{"The configured ring_creation_size (~B) should always be a power of 2. "
"Please reconfigure the ring_creation_size in app.config.", [S]};
"Please reconfigure the ring_creation_size in app.config.", [S]}.

%format({ring_size_too_small, S, N}) ->
% {"With a ring_creation_size (~B) and ~B nodes participating in the cluster, each node is responsible for less than 3% of the data. "
Expand Down

0 comments on commit 2f9f9a0

Please sign in to comment.