Skip to content

Conversation

@j-bmn
Copy link
Contributor

@j-bmn j-bmn commented Jul 28, 2025

This makes two changes to the handling of email addresses:

  • Email addresses may be specified as a list, instead of one single address.
    This is entirely optional, everything will still render correctly if only one address is specified (without list syntax).

  • Email addresses will be rendered as mailto: links, so that clicking them will open the default email client (if set).

For an example of the result, feel free to take a look at jonathan.baumann.cv ;)

@TheoWinterhalter
Copy link
Contributor

Thanks for the PR. I'm not sure about this one: I don't think it makes sense to advertise several email addresses, this is confusing. Ideally you tell people how to reach you, they shouldn't have to guess.

It's perfectly fine to have on your own version of course. As for the mailto link, I'm on the fence, which to me suggests that perhaps there should be an option to make it a link or not?

What do you think?

@TheoWinterhalter
Copy link
Contributor

I guess it doesn't hurt to support several emails, so if you make it optional to have the mailto link, I will merge.

@j-bmn
Copy link
Contributor Author

j-bmn commented Sep 1, 2025

Hi!
Sorry, it took me a while to get around to it, despite it being a really small change.

I decided to name the field clickable-email, but that can of course be changed if you prefer a different name.

Document that the `clickable-email` is a boolean, and false by default.
Adhere to 80 character limit in `template.html4`.
Copy link
Contributor

@TheoWinterhalter TheoWinterhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit and we're done. Thanks!

Co-authored-by: Théo Winterhalter <theo.winterhalter@gmail.com>
@TheoWinterhalter TheoWinterhalter merged commit 78aba52 into basicpage:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants