Merge pull request #90 from basil79/correct-ios-detection-ipados

fixed getVolume for iOS, on iOS the video slot volume is always 1 eve…
basil79 · Feb 10, 2023 · 05b23b1 · 05b23b1
2 parents be14a97 + 0a373b0
commit 05b23b1
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/dist/ads-manager.es.js b/dist/ads-manager.es.js
diff --git a/dist/ads-manager.js b/dist/ads-manager.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ads-manager",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "HTML5 Video Ads Manager based on @dailymotion/vast-client",
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

diff --git a/public/js/ads-manager.js b/public/js/ads-manager.js
diff --git a/src/ads-manager.js b/src/ads-manager.js
@@ -204,7 +204,7 @@ AdsManager.prototype.showSlot = function() {
   this._slot.style.display = 'block';
 };
 AdsManager.prototype.hideSlot = function() {
-  // Show slot
+  // Hide slot
   this._slot.style.display = 'none';
 };
 AdsManager.prototype.resizeSlot = function(width, height) {
@@ -1052,7 +1052,9 @@ AdsManager.prototype.getVolume = function() {
     if (this._isVPAID) {
       return this._isCreativeFunctionInvokable('getAdVolume') ? this._vpaidCreative.getAdVolume() : -1;
     }
-    return this._videoSlot.volume;
+    // on iOS the video slot volume is always 1 even if the video slot is muted,
+    // if video slot is muted, return 0, otherwise volume
+    return this._videoSlot.muted ? 0 : this._videoSlot.volume;
   }
 };
 AdsManager.prototype.setVolume = function(volume) {