New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Ignore EWMH Struts? #906

Closed
MyNameIsCosmo opened this Issue Jan 23, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@MyNameIsCosmo
Copy link
Contributor

MyNameIsCosmo commented Jan 23, 2019

I am using the latest bspwm from git (commit 644b200) and the latest polybar.
My current issue is that bspwm will respect monitor padding until polybar is reloaded, in which case it will increase the padding to whichever side polybar is.

I highly suspect this is due to the EWMH structs from #487

This issue started out after reloading polybar config
See the following video for an example:
https://www.youtube.com/watch?v=PPF7ZfwZlsM

This seems to affect the current desktop, even though bspc wm -d states that the monitor padding is set and not the desktop padding. The other desktops do not seem to be affected until i either reload my configuration when on the desktop, or close all windows.

Would it be OK to add a configuration to ignore EWMH struts?
I'd be happy following up with a PR if it would be accepted

@Eel52

This comment has been minimized.

Copy link

Eel52 commented Jan 23, 2019

I encounter this issue as well and have a workaround by creatibg a script module in Polybar and having it execute every second, the script simply runs bspc config top_padding 25, which seems to resolve it.

@MyNameIsCosmo

This comment has been minimized.

Copy link
Contributor Author

MyNameIsCosmo commented Jan 24, 2019

That isn't quite a solution I'd like to go with.
I'm happy submitting a patch to have an option to ignore struts.

Possibly related: #836

@Eel52

This comment has been minimized.

Copy link

Eel52 commented Jan 24, 2019

Do you want me to test your patch before you submit it?

@MyNameIsCosmo

This comment has been minimized.

Copy link
Contributor Author

MyNameIsCosmo commented Jan 25, 2019

Go ahead and test the PR if you'd like, it's a straight-forward configuration, and the impact should be minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment