-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth code upgrade is incomplete #21
Comments
Yep, really messy 😋 |
Agree with @qligier. In my fork of this project, I did use edwin-luijten/oauth2-strava instead of the local implementation here. It's been running successfully in production for a few weeks already. I'm happy to make a PR, once earlier #22 is approved. |
Adding the Strava provider from edwin-luijten/oauth2-strava sounds like a good idea. |
Stale issue message |
#18 recently upgraded dependency league/oauth2-client from 0.8.1 to 1.4.2. That old version was an alpha one, and the abstract methods to implement changed in the final release 1.0.
Specifically,
getUser*()
methods were removed on 9 May 2015, and some of the new ones are left unimplemented here, e.g.createResourceOwner()
. This is messy and should be fixed. I can take care of this.userUid()
,userEmail()
,userScreenName()
methods should be deprecated here, and removed in the next major release. The code to implement for the new methods is already available in Edwin-Luijten/oauth2-strava. We could copy it here (MIT license allows it), or make this package depend on it. Any preference?The text was updated successfully, but these errors were encountered: