Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows containers #275

Closed
DamianBis opened this issue Nov 13, 2019 · 2 comments
Closed

Windows containers #275

DamianBis opened this issue Nov 13, 2019 · 2 comments

Comments

@DamianBis
Copy link

@DamianBis DamianBis commented Nov 13, 2019

when running with windows containers i get errors.

"Error: An unexpected exception occurred during execution.
During execution of step of kind 'CreateTaskNetworkStep': java.net.SocketTimeoutException: Read timed out"

Based off of reading the documentation it's not explicitly there, but it seems implied that windows containers aren't supported.

Are there any plans for adding support for windows containers to batect? I imagine that most of what's being run by batect are docker commands so windows/linux containers shouldn't make much of a difference?

@charleskorn

This comment has been minimized.

Copy link
Collaborator

@charleskorn charleskorn commented Nov 13, 2019

Hey @DamianBis, thanks for the feedback. You're correct - Windows containers aren't supported, and that isn't explicitly called out in the docs. I'll add something to clarify this.

There are no plans to support Windows containers at the moment - given the relatively small number of people that use Windows containers it's not a priority, but I'd be happy for someone to contribute this (and I assume it wouldn't be too difficult to do, because as you say, batect is just using the Docker API under the hood).

At the very least, that error message could be clearer - I'll clarify that as well.

charleskorn added a commit that referenced this issue Dec 14, 2019
…ntainers mode, and clarify support for Windows containers in documentation.

See #275.
charleskorn added a commit that referenced this issue Jan 12, 2020
This is one of the pieces required to support Windows containers (#275).
charleskorn added a commit that referenced this issue Jan 12, 2020
See #275.
charleskorn added a commit that referenced this issue Jan 12, 2020
This enables support for Windows containers (#275).
charleskorn added a commit that referenced this issue Jan 18, 2020
See #275.
charleskorn added a commit that referenced this issue Jan 18, 2020
See #275.
@charleskorn

This comment has been minimized.

Copy link
Collaborator

@charleskorn charleskorn commented Jan 18, 2020

Good news - turns out this isn't hard to implement so I've added support for Windows containers and this will be part of the next release (which should be out shortly). Thanks again for your feedback @DamianBis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.