Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigrp: only compute metrics in the given mode #4065

Merged
merged 1 commit into from Jun 11, 2019

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Jun 11, 2019

Fix #4051

@dhalperi dhalperi requested a review from progwriter June 11, 2019 21:43
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #4065 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #4065      +/-   ##
============================================
- Coverage     75.03%   75.02%   -0.01%     
+ Complexity    24498    24492       -6     
============================================
  Files          2023     2023              
  Lines         98252    98253       +1     
  Branches      11676    11679       +3     
============================================
- Hits          73720    73714       -6     
- Misses        19215    19219       +4     
- Partials       5317     5320       +3
Impacted Files Coverage Δ Complexity Δ
.../org/batfish/datamodel/eigrp/EigrpProcessMode.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...in/java/org/batfish/datamodel/eigrp/EigrpEdge.java 60% <0%> (-1.54%) 11 <0> (ø)
.../java/org/batfish/datamodel/eigrp/EigrpMetric.java 91.76% <93.75%> (+1.17%) 25 <2> (-2) ⬇️
...rc/main/java/org/batfish/bddreachability/Edge.java 67.64% <0%> (-2.95%) 11% <0%> (-1%)
...java/org/batfish/datamodel/EigrpExternalRoute.java 75.47% <0%> (-1.89%) 12% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.6% <0%> (-0.73%) 69% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 83.92% <0%> (-0.13%) 531% <0%> (-1%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit f547844 into batfish:master Jun 11, 2019
@dhalperi dhalperi deleted the eigrp-only-compute-one-mode branch June 11, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIGRP Data Plane compute issue
3 participants