junos_then_action_conflicts: resolve next-term vs next-policy precedence#190
Merged
Conversation
Adds 4 §5 flow-control terms (4011-4014) to characterize how Junos collapses `next term` and `next policy` when both appear in the same `then` block, and recollects the lab on vJunos-router 25.4R1.12. Finding: `next term` and `next policy` are the same attribute family. A `then` block holds at most one of them — dedup collapses identical pairs, and last-wins applies to mixed pairs: - 4011 NT;NT -> NT (dedup; route falls through, no propagation) - 4012 NP;NP -> NP (dedup; route returns to BGP, propagates) - 4013 NT;NP -> NP (last-wins; route propagates) - 4014 NP;NT -> NT (last-wins; route falls through) In all four cases both side-effect `community add` lines survive the collapse and execute around the surviving terminator; the collector RIB confirms the runtime winner via which marker communities arrive. This generalizes the §1/§2/§3 last-wins rule to the named-disposition family and tightens the README synthesis prose accordingly. Prompt: ``` Let's iterate on the lab we just added in HEAD. Let's add a setup to resolve next-term vs next-policy (order sensitive or not, and which one wins?) ``` commit-id:69966ff8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 87 87
Lines 4204 4204
=======================================
Hits 3516 3516
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 4 §5 flow-control terms (4011-4014) to characterize how Junos
collapses
next termandnext policywhen both appear in the samethenblock, and recollects the lab on vJunos-router 25.4R1.12.Finding:
next termandnext policyare the same attribute family.A
thenblock holds at most one of them — dedup collapses identicalpairs, and last-wins applies to mixed pairs:
In all four cases both side-effect
community addlines survive thecollapse and execute around the surviving terminator; the collector
RIB confirms the runtime winner via which marker communities arrive.
This generalizes the §1/§2/§3 last-wins rule to the named-disposition
family and tightens the README synthesis prose accordingly.
Prompt:
Stack: