Batman.SetComplement a la Intersect/Union #375

Merged
merged 6 commits into from May 31, 2012

Projects

None yet

3 participants

@robholland
Contributor

Adds set complement, useful for splitting out matching and non-matching
model instances in a UI, amongst other things.

Rob Holland added some commits Apr 1, 2012
Rob Holland Allow flexible URL nesting. fd6562e
Rob Holland Small tidy up. Also favour the previously set parent, in case we're m…
…oving between nestings.
10b89fc
Rob Holland Batman.SetComplement a la Intersect/Union
Adds set complement, useful for splitting out matching and non-matching
model instances in a UI, amongst other things.
b2f52b9
Rob Holland Merge branches 'set_complement' and 'flexible_url_nesting' f9a50ac
Rob Holland Merge branch 'master' of https://github.com/Shopify/batman edbd422
@airhorns
Contributor
airhorns commented Apr 8, 2012

This is awesome @robholland, but I have a couple things to ask of you before merging. A) can we come up with a better name than MergeableSet for the super class of the set operations, and B) do we really need both SetOperation and BinarySetOperation? Can we just make SetUnion and SetIntersection SetOperation subclasses and rename SetOperation to BinarySetOperation?

@robholland
Contributor

I've not forgotten about this, just snowed under. I will look at this again soon.

@airhorns
Contributor
airhorns commented May 9, 2012

Hey @robholland, I'm going to close this for now. We haven't felt the need for this in Batman core. If you get a chance to look at it maybe we can add it as an extra in the extras folder, so feel free to reopen a pull request then :)

@airhorns airhorns closed this May 9, 2012
@robholland
Contributor

No problem, will do.

Rob Holland

On Wednesday, 9 May 2012 at 21:03, Harry Brundage wrote:

Hey @robholland, I'm going to close this for now. We haven't felt the need for this in Batman core. If you get a chance to look at it maybe we can add it as an extra in the extras folder, so feel free to reopen a pull request then :)


Reply to this email directly or view it on GitHub:
#375 (comment)

@airhorns airhorns reopened this May 31, 2012
@airhorns
Contributor

I changed my mind, I need this! Thanks @robholland!

@airhorns airhorns merged commit 821ab5f into batmanjs:master May 31, 2012
@rmosolgo rmosolgo removed the Code Review label Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment