The use-case here is a <a data-route="something" target="_blank"> within a modal. We are just using the data-route to set the href.
<a data-route="something" target="_blank">
@nickjs Just pushed a fix per your suggestion.
I started looking into route_rendering_test.coffee, but I'm currently on something else. I think we may be able to test this.
In any case, it isn't critical.
+1 on this. :)
@cjoudrey any progress on this?
@hornairs Haven't looked into this since I initially opened it.
I wasn't sure how we could test this. I could mock Batman.DOM.events.click but feels a little dirty.
@cjoudrey You have until Friday to test and ship this :)
FWIW - I've been running with this applied to a local copy for months. It works fine. Please merge!
I suppose the base functionality that you want to test is that we don't attach the click handler, so you could check Batman._data(node, 'listeners').click.length and assert it's 0.
Feels dirty to test the implementation. I would trigger a click and just make sure it doesn't do anything.
Allow click events to propagate for anchors with target="_blank"
Fix previously broken data-route tests
@cjoudrey I added a test for this, let me know what you think.
LGTM 🚢 💨
Thanks for owning this. 👍
@nickjs or @SoapyIllusions if you can once-over this we can finally get it out 🚶
Looks good to me.