Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting citation keys #1

Closed
daijiang opened this issue Oct 23, 2018 · 6 comments
Closed

Highlighting citation keys #1

daijiang opened this issue Oct 23, 2018 · 6 comments
Labels
enhancement New feature or request scopes Additional syntax-highlighting scopes

Comments

@daijiang
Copy link

Thanks for the awesome theme! I just tried it and I love it! There are a couple of things that I wonder can you improve it?

To see this, create a new RMarkdown file within RStudio, then add the following sentence in the body.

This is an R Markdown document [@citation]. And (_italic with blank within parathese immediately_).
( _italic with blank within parathese with heading space_).

image

Can you change the color of the citation key? Also, the italic within parenthesis without a heading space does not work.

Thanks!

@batpigandme
Copy link
Owner

Alas, I'm limited to the scopes that already exist in the built-in themes. I typically test against Tomorrow Night Bright (see screenshot of the above, below), but if there is a built-in theme that differentiates the above syntax, let me know which one, and I can look into it when time allows.
image

I looked at a few others (e.g. Solarized Dark, below) and didn't happen to see any that worked with this, but I didn't go through them all.
image

@batpigandme batpigandme added enhancement New feature or request scopes Additional syntax-highlighting scopes labels Oct 23, 2018
@daijiang
Copy link
Author

Thanks. For the citation key, I think the default one (teammate), Chrome, and Twilight work. But none for the italic one...

@batpigandme
Copy link
Owner

Interesting. Yeah, so unless the scope is added for italics, that one won't happen (sorry). With Chrome at least, the citation has the list class (.ace_list) style applied to it, but I'll have to dig deeper to see if it has different selectors build in as well.

@daijiang
Copy link
Author

Thanks!!

@batpigandme
Copy link
Owner

💥 scope added!
citation key highlight

@daijiang
Copy link
Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scopes Additional syntax-highlighting scopes
Projects
None yet
Development

No branches or pull requests

2 participants