Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globbing issue in run command #152

Closed
wants to merge 1 commit into from
Closed

Fix globbing issue in run command #152

wants to merge 1 commit into from

Conversation

joshfactorial
Copy link

@joshfactorial joshfactorial requested a review from a team as a code owner October 11, 2018 15:43
mbland
mbland suggested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@mbland mbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some benchmarks and tests, and I need to uncover whether a corner case with IFS=$'\n' read outside of a while could crop up here. Otherwise, this is a good start.

@cdevinesr cdevinesr mentioned this pull request Nov 6, 2018
Closed
@Flamefire Flamefire mentioned this pull request Jun 13, 2019
Merged
2 tasks
@Flamefire
Copy link
Contributor

#158 is the better solution. @mbland any chance to merge that one?

@martin-schulze-vireso martin-schulze-vireso mentioned this pull request Nov 7, 2020
Closed
1 task
@martin-schulze-vireso martin-schulze-vireso added Component: Bash Code Everything regarding the bash code Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Status: Confirmed The reproducer worked as described Type: Bug labels Jul 24, 2021
@martin-schulze-vireso martin-schulze-vireso added this to the 1.5.0 milestone Jul 24, 2021
@martin-schulze-vireso
Copy link
Member

Closing this in favor of #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbland mbland mbland requested changes

Assignees
No one assigned
Labels
Component: Bash Code Everything regarding the bash code Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Status: Confirmed The reproducer worked as described Type: Bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@joshfactorial @Flamefire @martin-schulze-vireso @mbland