Fix globbing issue in run command#152
Closed
joshfactorial wants to merge 1 commit into
Closed
Conversation
joshfactorial
commented
Oct 11, 2018
joshfactorial
commented
- I have reviewed the Contributor Guidelines.
- I have reviewed the Code of Conduct and agree to abide by it
mbland
suggested changes
Oct 11, 2018
Contributor
mbland
left a comment
mbland
left a comment
There was a problem hiding this comment.
This will need some benchmarks and tests, and I need to uncover whether a corner case with IFS=$'\n' read outside of a while could crop up here. Otherwise, this is a good start.
Contributor
1 task
martin-schulze-vireso
added
Component: Bash Code
Member
|
Closing this in favor of #158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.