Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globbing issue in run command #152

Closed

Conversation

joshfactorial
Copy link

@joshfactorial joshfactorial commented Oct 11, 2018

@joshfactorial joshfactorial requested a review from as a code owner Oct 11, 2018
Copy link
Contributor

@mbland mbland left a comment

This will need some benchmarks and tests, and I need to uncover whether a corner case with IFS=$'\n' read outside of a while could crop up here. Otherwise, this is a good start.

@Flamefire Flamefire mentioned this pull request Jun 13, 2019
2 tasks
@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jun 13, 2019

#158 is the better solution. @mbland any chance to merge that one?

@martin-schulze-vireso martin-schulze-vireso added Component: Bash Code Priority: Critical Status: Confirmed Type: Bug labels Jul 24, 2021
@martin-schulze-vireso martin-schulze-vireso added this to the 1.5.0 milestone Jul 24, 2021
@martin-schulze-vireso
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso commented Jul 24, 2021

Closing this in favor of #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Bash Code Priority: Critical Status: Confirmed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants