Skip to content

Don't glob output - #158

Merged
martin-schulze-vireso merged 1 commit into
bats-core:masterfrom
vonbrand:dont-glob-output
Jul 24, 2021
Merged

Don't glob output#158
martin-schulze-vireso merged 1 commit into
bats-core:masterfrom
vonbrand:dont-glob-output

Conversation

@vonbrand

@vonbrand vonbrand commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

If the output contains shell metacharacters, like '*', it can get
mangled by shell globbing. Turn it off for test runs.

Signed-off-by: Horst H. von Brand vonbrand@inf.utfsm.cl

fixes #156, fixes #281

@vonbrand
vonbrand requested a review from a team as a code owner November 7, 2018 12:10
@vonbrand

Copy link
Copy Markdown
Contributor Author

Just rebased on the latest upstream

@piotr1212

Copy link
Copy Markdown

this fixes: #156

@Flamefire

Copy link
Copy Markdown
Contributor

Better than #152. Can you rebase and @bats-core can you merge?

@Flamefire Flamefire mentioned this pull request Jun 13, 2019
2 tasks
Comment thread libexec/bats-core/bats-exec-test Outdated
Comment thread test/bats.bats
@jasonkarns

Copy link
Copy Markdown
Member

@vonbrand would you mind rebasing?

This looks good to me, @bats-core/bats-core others?

@martin-schulze-vireso martin-schulze-vireso added Component: Bash Code Everything regarding the bash code Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Type: Bug labels Jul 24, 2021
@martin-schulze-vireso martin-schulze-vireso added this to the 1.5.0 milestone Jul 24, 2021
If the output contains shell metacharacters, like '*', it can get
mangled by shell globbing. Turn it off for test runs.
@martin-schulze-vireso

Copy link
Copy Markdown
Member

I had to rebase and re-sign the commits. I also squashed them and removed the failed merge conflict resolution.

@martin-schulze-vireso
martin-schulze-vireso merged commit 5218bbc into bats-core:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Bash Code Everything regarding the bash code Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run function is susceptible to globbing Command output gets globbed

5 participants