-
Notifications
You must be signed in to change notification settings - Fork 430
Don't glob output #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martin-schulze-vireso
merged 1 commit into
bats-core:master
from
vonbrand:dont-glob-output
Jul 24, 2021
Merged
Don't glob output #158
martin-schulze-vireso
merged 1 commit into
bats-core:master
from
vonbrand:dont-glob-output
Jul 24, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f326353
to
8963a22
Compare
Just rebased on the latest upstream |
this fixes: #156 |
Better than #152. Can you rebase and @bats-core can you merge? |
2 tasks
Flamefire
reviewed
Jun 20, 2019
Flamefire
reviewed
Jun 20, 2019
@vonbrand would you mind rebasing? This looks good to me, @bats-core/bats-core others? |
1 task
2 tasks
eaa218a
to
2ab302d
Compare
martin-schulze-vireso
approved these changes
Jul 24, 2021
If the output contains shell metacharacters, like '*', it can get mangled by shell globbing. Turn it off for test runs.
2ab302d
to
14e8b32
Compare
I had to rebase and re-sign the commits. I also squashed them and removed the failed merge conflict resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Bash Code
Everything regarding the bash code
Priority: Critical
Broken behavior in nearly all environments, e.g. wrong test results, internal bats error
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output contains shell metacharacters, like '*', it can get
mangled by shell globbing. Turn it off for test runs.
Signed-off-by: Horst H. von Brand vonbrand@inf.utfsm.cl
fixes #156, fixes #281