Fix the implementation of the run helper function to properly parse lines of output #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines of output. The existing behavior is broken, as it relies on the shell to word-split unquoted variables. This breaks down in several ways, notably that empty lines are silently dropped, but also because wordsplitting also triggers globbing, so any line that happens to match a shell glob will be expanded in the resulting array.
This was referenced Apr 27, 2020
|
Thanks @dimo414, give me some time to parse and test this. As it's a breaking change we may want to release 1.4.0 first too, but will get that done sooner rather than later (haven't build a roadmap yet). |
|
Another option, as mentioned in #249, would be to move this behavior to a new function and deprecate |
|
Closing this In fact, I am using both. Your code can preserve empty lines while the other can't. However, when we are not interested in that, the other one is about 20x more performant, which becomes noticable on large inputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The existing behavior is broken, as it relies on the shell to word-split unquoted variables. This breaks down in several ways, notably that empty lines are silently dropped, but also because words-splitting also triggers globbing, so any line that happens to match a shell glob will be expanded in the resulting array.
This is a breaking change, but the existing behavior is fundamentally broken and does not work as documented.
Fixes #281 and #284