Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation to sphinx #346

Conversation

martin-schulze-vireso
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso commented Sep 2, 2020

This is a first step towards hosting version specific documentation as discussed in #318.

  • how to update the documentation version automatically with a new release?

  • remove warning about unreleased features

  • I have reviewed the Contributor Guidelines.

  • I have reviewed the Code of Conduct and agree to abide by it

@martin-schulze-vireso martin-schulze-vireso requested a review from a team as a code owner September 2, 2020 22:49
@martin-schulze-vireso
Copy link
Member Author

I just c&p'd most of the readme over into specific subsections of the Sphinx based documentation and replaced the hardcoded bats --help output with dynamic output from a run of the local version. We would still need to create the right environment with sphinx + recommonmark + sphinx-contrib on it and host the output of cd docs; make html; somewhere on the internet to make it readable.

Copy link
Member

@sublimino sublimino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just re-signed and awaiting build

@sublimino sublimino force-pushed the feature/documentation_via_sphinx branch from 0864b91 to 5d47118 Compare September 7, 2020 12:40
@martin-schulze-vireso
Copy link
Member Author

This is part of getting the documentation onto github pages or read the docs. As is, we would throw away the documentation. Do we have a decision how to display the results @sublimino? We also need to deal with the versioning.

@martin-schulze-vireso martin-schulze-vireso changed the title Move documentation to sphinx WIP: Move documentation to sphinx Sep 7, 2020
@sublimino
Copy link
Member

My only preference is simplicity, is GitHub pages easier perhaps?

@martin-schulze-vireso martin-schulze-vireso force-pushed the feature/documentation_via_sphinx branch 2 times, most recently from aff9643 to 5a4cbce Compare September 21, 2020 21:38
@martin-schulze-vireso
Copy link
Member Author

martin-schulze-vireso commented Sep 21, 2020

A first try of this can be seen here: https://martin-schulze-vireso.github.io/bats-core/master/

I think the design and ease of versioning integration would be better on read the docs.

@martin-schulze-vireso martin-schulze-vireso changed the title WIP: Move documentation to sphinx Move documentation to sphinx Sep 25, 2020
@martin-schulze-vireso
Copy link
Member Author

So we won't get the deploy stage green at this point because sphinx will try to build the refs master and version tags but there are non with sphinx documentation so far. Additionally, according to the documentation we need the environment variable GITHUB_TOKEN in travis to be filled with a personal access token with the public_repo scope.

@martin-schulze-vireso martin-schulze-vireso added this to In progress in 1.3 roadmap via automation Nov 23, 2020
@martin-schulze-vireso martin-schulze-vireso force-pushed the feature/documentation_via_sphinx branch 3 times, most recently from 46e12b2 to 73f5836 Compare November 23, 2020 23:26
@martin-schulze-vireso
Copy link
Member Author

martin-schulze-vireso commented Nov 23, 2020

I moved this over to read the docs: https://bats-core.readthedocs.io/en/feature-documentation_via_sphinx/
This leaves us with the following steps:

  • migrate to the actual bats-core/bats-core project (instead of my fork)
  • add other maintainers' accounts on read the docs
  • add an automation for activating new versions

@martin-schulze-vireso
Copy link
Member Author

This PRs documentation can be seen at https://bats-core--346.org.readthedocs.build/en/346/

@sublimino
Copy link
Member

This is ready to merge from my perspective, but there's an unexpected Bash 5-only test failure, which I hope isn't a breaking Bash change but haven't yet debugged.

@martin-schulze-vireso
Copy link
Member Author

From a first glance it looks like GNU parallel is not being found.

.travis.yml Outdated Show resolved Hide resolved
@martin-schulze-vireso
Copy link
Member Author

Some days ago bash:5.1 has been released, which shows this error. bash:5.0 does not. I bisected on 5.1 to this commit 3ed95c4. I am looking into the problem but it is unrelated to this PR since it was already present on older commits with bash:5.1

@martin-schulze-vireso
Copy link
Member Author

@sublimino I think this is ready now.

@sublimino
Copy link
Member

Thanks @martin-schulze-vireso, I dug through https://github.com/bminor/bash/blob/master/CHANGES but couldn't see anything jump out. Good find.

And great work on getting functional documentation for the project!! 🎆 🎉

@sublimino sublimino force-pushed the feature/documentation_via_sphinx branch from 9802cca to f7c5af8 Compare December 16, 2020 10:50
@sublimino
Copy link
Member

(I had to sign your commits to merge to master @martin-schulze-vireso)

@martin-schulze-vireso
Copy link
Member Author

Thanks @sublimino, signing is not part of my default workflow, so I sometimes forget the final signing rebase.

@sublimino sublimino merged commit e81e2ef into bats-core:master Dec 16, 2020
1.3 roadmap automation moved this from In progress to Done Dec 16, 2020
@jasonkarns
Copy link
Member

Thanks @sublimino, signing is not part of my default workflow, so I sometimes forget the final signing rebase.

@martin-schulze-vireso You can configure git to sign by default in just the bats-core repo, if you don't want to sign by default in all your git repos. git config commit.gpgsign true

@martin-schulze-vireso martin-schulze-vireso deleted the feature/documentation_via_sphinx branch May 23, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.3 roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants