New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation to sphinx #346
Move documentation to sphinx #346
Conversation
I just c&p'd most of the readme over into specific subsections of the Sphinx based documentation and replaced the hardcoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just re-signed and awaiting build
0864b91
to
5d47118
Compare
This is part of getting the documentation onto github pages or read the docs. As is, we would throw away the documentation. Do we have a decision how to display the results @sublimino? We also need to deal with the versioning. |
My only preference is simplicity, is GitHub pages easier perhaps? |
aff9643
to
5a4cbce
Compare
A first try of this can be seen here: https://martin-schulze-vireso.github.io/bats-core/master/ I think the design and ease of versioning integration would be better on read the docs. |
So we won't get the deploy stage green at this point because sphinx will try to build the refs master and version tags but there are non with sphinx documentation so far. Additionally, according to the documentation we need the environment variable GITHUB_TOKEN in travis to be filled with a personal access token with the |
46e12b2
to
73f5836
Compare
I moved this over to read the docs: https://bats-core.readthedocs.io/en/feature-documentation_via_sphinx/
|
73f5836
to
1f312d5
Compare
1f312d5
to
ca522aa
Compare
This PRs documentation can be seen at https://bats-core--346.org.readthedocs.build/en/346/ |
This is ready to merge from my perspective, but there's an unexpected Bash 5-only test failure, which I hope isn't a breaking Bash change but haven't yet debugged. |
From a first glance it looks like GNU parallel is not being found. |
Some days ago bash:5.1 has been released, which shows this error. bash:5.0 does not. I bisected on 5.1 to this commit 3ed95c4. I am looking into the problem but it is unrelated to this PR since it was already present on older commits with bash:5.1 |
@sublimino I think this is ready now. |
Thanks @martin-schulze-vireso, I dug through https://github.com/bminor/bash/blob/master/CHANGES but couldn't see anything jump out. Good find. And great work on getting functional documentation for the project!! 🎆 🎉 |
9802cca
to
f7c5af8
Compare
(I had to sign your commits to merge to master @martin-schulze-vireso) |
Thanks @sublimino, signing is not part of my default workflow, so I sometimes forget the final signing rebase. |
f7c5af8
to
fb82ed0
Compare
@martin-schulze-vireso You can configure git to sign by default in just the bats-core repo, if you don't want to sign by default in all your git repos. |
This is a first step towards hosting version specific documentation as discussed in #318.
how to update the documentation version automatically with a new release?
remove warning about unreleased features
I have reviewed the Contributor Guidelines.
I have reviewed the Code of Conduct and agree to abide by it