Return early when result is empty in verify_value #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the result is empty in an assertion, `verify_value` returns 0, which causes the test to succeed when it should fail. The test I used for this was ``` run verify "'status' is 'running' for pods named 'app'" ``` When that pod doesn't exist prior to this change, the test would succeed.
|
Thank you for this contribution. Could you also add a test that was failing before this addition? |
|
Actually, I have checked your patch and it breaks some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the result is empty in an assertion,
verify_valuereturns 0, which causes the test to succeed when it should fail. The test I used for this wasWhen that pod doesn't exist prior to this change, the test would succeed.