Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix lint and charm proof errors #14
Conversation
| @@ -1,6 +1,8 @@ | ||
| name: nginx | ||
| +maintainers: ['Adam Stokes <adam.stokes@ubuntu.com>'] |
marcoceppi
Nov 16, 2016
Collaborator
This is a layer and not a charm. Maintainers field should not be populated here. Otherwise it shows up for top layers including this.
charm proof is run against a compiled charm and not against a single layer
ktsakalozos
Nov 16, 2016
Contributor
Fair enough, I dropped the maintainers and tags in the last commit.
marcoceppi
merged commit 1300106
into
battlemidget:master
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ktsakalozos commentedNov 16, 2016
Should also fix some of the Kubernetes bundle failures on CWR
Fixes:
charm proof
and make lint