Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
WIP: Modernize layer to use new primitives #8
Conversation
|
@battlemidget this takes some liberal opinions, while I wrap up the last bits I'm curious of feedback. |
mbruzek
reviewed
Aug 30, 2016
| + kind = "dynamic" | ||
| + | ||
| + def __call__(self): | ||
| + print('DIE FUCKER') |
battlemidget
Aug 30, 2016
Owner
feel free to open a new PR for the profanity, or leave it for flair.
battlemidget
merged commit e477bf6
into
battlemidget:master
Aug 30, 2016
|
This was not ready to merge |
battlemidget
referenced this pull request
Aug 30, 2016
Merged
Revert "WIP: Modernize layer to use new primitives" #10
|
Yea sorry, please re-open, I didnt see the WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
marcoceppi commentedAug 30, 2016
This is much like battlemidget/juju-layer-nginx#6 but pushes even further on the idea. I made sure
rubylibis available for backwards compat, but ultimately this will make things work as most others do today.The last thing I want to do is build a custom tactic that helps warn/error for those using dependency.txt in their charm so that people can update without problem