New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp support for node 0.6.x #12

Merged
merged 2 commits into from May 22, 2012

Conversation

Projects
None yet
2 participants
@japj
Contributor

japj commented May 20, 2012

This is a patch for adding gyp support for running with node 0.6.x.

I also updated the tests to use the new bindings (build) path and to not use require.paths since that was removed.

I'm not sure how you want to handle 0.4.x support for your library.

You can manually test this by applying this pull request and:
npm install -g node-gyp
cd node-fs-ext
node-gyp configure
node-gyp build
npm test

To complete the migration to node-gyp, the 'install' line (containing node-waf) should be removed from the package.json

baudehlo added a commit that referenced this pull request May 22, 2012

Merge pull request #12 from japj/gyp
gyp support for node 0.6.x

@baudehlo baudehlo merged commit d7aed7e into baudehlo:master May 22, 2012

@baudehlo

This comment has been minimized.

Show comment
Hide comment
@baudehlo

baudehlo May 22, 2012

Owner

Thanks. Merged.

Owner

baudehlo commented May 22, 2012

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment