Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

gyp support for node 0.6.x #12

Merged
merged 2 commits into from

2 participants

@japj

This is a patch for adding gyp support for running with node 0.6.x.

I also updated the tests to use the new bindings (build) path and to not use require.paths since that was removed.

I'm not sure how you want to handle 0.4.x support for your library.

You can manually test this by applying this pull request and:
npm install -g node-gyp
cd node-fs-ext
node-gyp configure
node-gyp build
npm test

To complete the migration to node-gyp, the 'install' line (containing node-waf) should be removed from the package.json

@baudehlo baudehlo merged commit d7aed7e into from
@baudehlo
Owner

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 20, 2012
  1. @japj

    adding binding.gyp

    japj authored
  2. @japj
This page is out of date. Refresh to see the latest.
View
10 binding.gyp
@@ -0,0 +1,10 @@
+{
+ "targets": [
+ {
+ "target_name": "fs-ext",
+ "sources": [
+ "fs-ext.cc"
+ ]
+ }
+ ]
+}
View
4 tests/test-fs-flock.js
@@ -20,8 +20,6 @@
// argument values, rather than calling the callback with the error?
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
@@ -154,7 +152,7 @@ if ( tests_run !== tests_ok ) {
// Test that constants are published - - - - - - - -
-var fs_binding = require('../build/default/fs-ext');
+var fs_binding = require('../build/Release/fs-ext');
var constant_names = [ 'LOCK_EX', 'LOCK_NB', 'LOCK_SH', 'LOCK_UN' ];
View
2  tests/test-fs-flock_stress.js
@@ -19,8 +19,6 @@
//TODO and Questions
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
View
4 tests/test-fs-seek.js
@@ -41,8 +41,6 @@
// constants from system library values.
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
@@ -248,7 +246,7 @@ if ( tests_run !== tests_ok ) {
// Test that constants are published - - - - - - - -
-var fs_binding = require('../build/default/fs-ext');
+var fs_binding = require('../build/Release/fs-ext');
var constant_names = [ 'SEEK_SET', 'SEEK_CUR', 'SEEK_END' ];
View
2  tests/test-fs-seek_stress.js
@@ -22,8 +22,6 @@
// Ideas for testing borrowed from bnoordhuis (Ben Noordhuis)
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
View
2  tests/test-fs-utime.js
@@ -19,8 +19,6 @@
// They do! Just not documented!
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
View
2  tests/test-fs-utime_stress.js
@@ -17,8 +17,6 @@
//TODO and Questions
-// Make this new-built copy of fs-ext available for testing
-require.paths.unshift(__dirname + '/..');
// console.log( require.resolve('../fs-ext'));
var assert = require('assert'),
Something went wrong with that request. Please try again.