2010-04-07 Gonzalo Paniagua Javier <gonzalo@novell.com>

* zlib-helper.c: now that we don't use Z_SYNC_FLUSH, there might be unflushed input in zstream, so always call Z_FINISH. svn path=/branches/mono-2-4/mono/; revision=154997
baulig · Apr 7, 2010 · 2a736ca · 2a736ca
1 parent 438882b
commit 2a736ca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/support/ChangeLog b/support/ChangeLog
@@ -1,3 +1,8 @@
+2010-04-07 Gonzalo Paniagua Javier <gonzalo@novell.com>
+
+	* zlib-helper.c: now that we don't use Z_SYNC_FLUSH, there might be
+	unflushed input in zstream, so always call Z_FINISH.
+
 2010-01-28 Gonzalo Paniagua Javier <gonzalo@novell.com>
 
 	* zlib-helper.c: no need for sync flush when compressing.

diff --git a/support/zlib-helper.c b/support/zlib-helper.c
@@ -103,14 +103,12 @@ CloseZStream (ZStream *zstream)
 
 	status = 0;
 	if (zstream->compress) {
-		if (zstream->stream->total_out) {
-			do {
-				status = deflate (zstream->stream, Z_FINISH);
-				flush_status = Flush (zstream);
-			} while (status == Z_OK); /* We want Z_STREAM_END or error here here */
-			if (status == Z_STREAM_END)
-				status = flush_status;
-		}
+		do {
+			status = deflate (zstream->stream, Z_FINISH);
+			flush_status = Flush (zstream);
+		} while (status == Z_OK); /* We want Z_STREAM_END or error here here */
+		if (status == Z_STREAM_END)
+			status = flush_status;
 		deflateEnd (zstream->stream);
 	} else {
 		inflateEnd (zstream->stream);