Implement merchant fee deduction logic in PrepareService and HasGift trait #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rez1dent3
commented
Nov 17, 2025
rez1dent3
commented
- Added support for deducting fees from merchant payouts in PrepareService and HasGift trait.
- Introduced MerchantFeeDeductible interface to determine fee handling based on the product type.
- Updated transaction calculations to ensure correct amounts for both customer withdrawals and merchant deposits.
- Enhanced code clarity with comments explaining the fee deduction logic.
…trait - Added support for deducting fees from merchant payouts in PrepareService and HasGift trait. - Introduced MerchantFeeDeductible interface to determine fee handling based on the product type. - Updated transaction calculations to ensure correct amounts for both customer withdrawals and merchant deposits. - Enhanced code clarity with comments explaining the fee deduction logic.
…uctible and MerchantFeeDeductibleTest - Updated PHPDoc annotations to use 'list<string>' for fillable properties in ItemMerchantFeeDeductible. - Enhanced type hints in MerchantFeeDeductibleTest for better clarity and maintainability. - Removed unnecessary assertions and whitespace for cleaner test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.