-
-
Notifications
You must be signed in to change notification settings - Fork 247
Extend Wallet holder_id property to support string type #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Wallet holder_id property to support string type #423
Conversation
865cb6a to
8c4abe7
Compare
|
@adesege Maybe I'll pick up this MR, but definitely not in the near future.
At the moment, I'm throwing it on the back burner. |
|
Hi @rez1dent3, thanks for the comment.
I'm sure there are other people who use uuid strings as their primary id as well. Let me know if there is a temporary way of solving this without extending core. Thanks. |
|
@adesege There is another suggestion. I suggest postponing your pull request until laravel 9 is released. The new version will remove support for php 7.4 and I was going to remove support for old laravel versions in laravel-wallet 8+. |
|
Great! Laravel 9 will be released by Jan. 25th. I can wait till then. Thanks. |
|
Hey @rez1dent3, I've added another commit to extend Transfer DTO assembler and contract. |
|
@rez1dent3 I've opened another PR to add string support for wallet id in transaction dto interface here #427 |
|
@adesege hello. |
This PR extends wallet holder_id property to support string type.
In my use case, user id and item id are uuid strings.