create_provider is deprecated

[iphydf]

external/io_bazel_rules_scala/scala/private/common.bzl", line 122, in create_java_provider
                java_common.create_provider(use_ijar = False, compile_time_jar..., <3 more arguments>)
create_provider is deprecated and cannot be used when --incompatible_disallow_legacy_javainfo is set. Please migrate to the JavaInfo constructor.

Tested with eeee467.

[ittaiz]

by the way, just to link here this thread points to a probable blocker in moving to the new API (since scala_library generates two JavaInfo providers) https://groups.google.com/forum/#!topic/bazel-sig-jvm/THl2DRqyYW0

[ittaiz]

#781 aims to fix this

[long-stripe]

@ittaiz I believe this can be closed now.

> rg "create_provider"                                                                                                                                                                                                                                            (sc:no-domain)
test_expect_failure/scala_import/BUILD
8:    name = "dummy_dependency_to_trigger_create_provider_transitive_compile_jar_usage",
15:    deps = [":dummy_dependency_to_trigger_create_provider_transitive_compile_jar_usage"],

and #781 was merged.