resource_strip_prefix doesn't work on windows

[redbaron]

At least some of path handling is done based on strings, which breaks when running on windows. For example resource_strip_prefix:

https://github.com/bazelbuild/rules_scala/blob/da5ba6d97a1abdadef89d509b30a9dcfde7ffbe4/src/java/io/bazel/rulesscala/scalac/ScalacProcessor.java#L327-L331

For comparison here is how same code looks in Bazel:

https://github.com/bazelbuild/bazel/blob/6379ef5475217b3cf60038130cb83e4d45728b38/src/main/java/com/google/devtools/build/lib/rules/java/JavaHelper.java#L124-L135

[ittaiz]

Interesting. Any chance you want to contribute a fix? Sounds small and isolated. What I’d really like is to get a PR that enables windows on CI since I guess that will break the test and drive this change. Are you using rules_scala on windows? That’s exciting

…

On Tue, 1 Jan 2019 at 2:50 Maxim Ivanov ***@***.***> wrote: At least some of path handling is done based on strings, which breaks when running on windows. For example resource_strip_prefix: https://github.com/bazelbuild/rules_scala/blob/da5ba6d97a1abdadef89d509b30a9dcfde7ffbe4/src/java/io/bazel/rulesscala/scalac/ScalacProcessor.java#L327-L331 For comparison here is how same code looks in Bazel: https://github.com/bazelbuild/bazel/blob/6379ef5475217b3cf60038130cb83e4d45728b38/src/main/java/com/google/devtools/build/lib/rules/java/JavaHelper.java#L124-L135 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#655>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF7UrIBl3c4L9qg18i-Ga7si-0k-Sks5u-rC_gaJpZM4ZluJz> .

[redbaron]

@ittaiz , I am not very fluent with neither scala nor java :)

[ittaiz]

sorry for the late reply. Traveling.
@anchlovi can you pick up the small isolated change? I assume turning on Windows support will be a bigger task.
@redbaron Are you using rules_scala on windows?

[redbaron]

@ittaiz , I can't say I am using it yet. I am looking at what can be done with slow sbt build times and bazel was one of the options I explored

[ittaiz]

👍🏽 We’ll take this one but honestly I’m not sure how many gaps we have. I’d love to support windows as well but will probably need some more help from your side.

…

On Wed, 23 Jan 2019 at 3:04 Maxim Ivanov ***@***.***> wrote: @ittaiz <https://github.com/ittaiz> , I can't say I am using it yet. I am looking at what can be done with slow sbt build times and bazel was one of the options I explored — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#655 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF62BCpL2ECSTiHFhT3UbLqJBStOQks5vGBeVgaJpZM4ZluJz> .