Add rules_swift 1.2.0 #247
Conversation
BalestraPatrick
force-pushed
the
rules-swift
branch
from
d3cf92e
to
3c8ffb9
Compare
|
@BalestraPatrick Please add repository information to |
| bazel_dep(name = "bazel_skylib", version = "1.1.1") | ||
| bazel_dep(name = "apple_support", repo_name = "build_bazel_apple_support", version = "1.3.1") | ||
| bazel_dep(name = "rules_cc", version = "0.0.2") | ||
| bazel_dep(name = "protobuf", repo_name = "com_google_protobuf", version = "3.19.2") # To be removed once rules_proto is bzlmod-ready. |
There was a problem hiding this comment.
rules_proto is available in the BCR and could be added as a module dependency.
There was a problem hiding this comment.
The only version available is 4.0.0 which doesn't depend on protobuf itself, so this is why this is needed: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/rules_proto/4.0.0/MODULE.bazel
If we check-in a newer version of 4.0.0, we could probably specify it as a module dependency.
https://github.com/bazelbuild/rules_proto/blob/master/MODULE.bazel
There was a problem hiding this comment.
You can certainly keep it this way for the first version, but having an updated version of rules_proto would of course prevent potentially duplicating it in the dependency tree.
| "com_github_apple_swift_nio_transport_services", | ||
| "com_github_apple_swift_nio_extras", | ||
| "com_github_apple_swift_log", | ||
| "com_github_nlohmann_json", |
There was a problem hiding this comment.
Doesn't have to be done as part of this PR, but this library would be very useful to have as a Bazel module.
|
@BalestraPatrick Unblocked, but there is a different issue now. The bzl file defining extensions isn't found. |
|
Yeah that's expected, the module extension was added after that release was cut. I can add a patch for this specific release. |
|
|
||
| matrix: | ||
| platform: | ||
| - ubuntu2004 |
There was a problem hiding this comment.
Once bazelbuild/rules_swift#832 is merged, we could try adding Windows here as well.
BalestraPatrick
force-pushed
the
rules-swift
branch
from
f9b7af7
to
053b083
Compare
We do the same in the `rules_swift` repo: https://github.com/bazelbuild/rules_swift/blob/b6a111ea475da15793dfa5dda7e3e3646658f407/.bazelci/presubmit.yml#L24-L27
BalestraPatrick
force-pushed
the
rules-swift
branch
from
053b083
to
a4110d1
Compare
This PR adds the current release of
rules_swiftto the central registry. The patch will be useless in the next version that we'll hopefully cut soon.