New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard code dependency resolution bindings for @go_googleapis and WKTs #251

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
1 participant
@jayconrod
Collaborator

jayconrod commented Jul 2, 2018

  • proto.csv is a table that lists Well Known .proto files and all
    .proto files in @go_googleapis. For each proto import string, it
    lists the proto_library label, the Go import path, and the
    go_proto_library label. This was generated using an ad hoc Python
    script (not included).
  • Maps are generated from this file and incorporated into the
    dependency resolution logic in the proto and go extensions.

When #12 is implemented, we can index rules in external repositories,
and we won't need this. We need it for now because there's no clear
correspondence between proto and Go import strings and the libraries
that should be included.

Related bazelbuild/rules_go#1548

@jayconrod jayconrod requested a review from ianthehat Jul 2, 2018

Hard code dependency resolution bindings for @go_googleapis and WKTs
* proto.csv is a table that lists Well Known .proto files and all
  .proto files in @go_googleapis. For each proto import string, it
  lists the proto_library label, the Go import path, and the
  go_proto_library label. This was generated using an ad hoc Python
  script (not included).
* Maps are generated from this file and incorporated into the
  dependency resolution logic in the proto and go extensions.

When #12 is implemented, we can index rules in external repositories,
and we won't need this. We need it for now because there's no clear
correspondence between proto and Go import strings and the libraries
that should be included.

Related bazelbuild/rules_go#1548

@jayconrod jayconrod merged commit 79cf429 into bazelbuild:master Jul 3, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jayconrod jayconrod deleted the jayconrod:googleapis-resolve branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment