Allow setting proto_strip_import_prefix from root BUILD.bazel #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linzhp not a maintainer of Gazelle, but you might consider adding some tests to demonstrate the old broken behavior and ensure that there are no regressions. |
jayconrod
approved these changes
Jan 6, 2021
| @@ -282,7 +282,7 @@ func checkStripImportPrefix(prefix, rel string) error { | |||
| if !strings.HasPrefix(prefix, "/") { | |||
| return fmt.Errorf("proto_strip_import_prefix should start with '/' for a prefix relative to the repository root") | |||
| } | |||
| if !pathtools.HasPrefix(rel, prefix[1:]) { | |||
| if rel != "" && !pathtools.HasPrefix(rel, prefix[1:]) { | |||
There was a problem hiding this comment.
If this ends up being repeated anywhere else, it might make sense for pathtools.HasPrefix and TrimPrefix to support empty paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
language/proto
What does this PR do? Why is it needed?
In
go_repositoryrules, all Gazelle directives are at the root level BUILD.bazel. We should allow settingproto_strip_import_prefixat the root BUILD.bazel without warnings