Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support for build_test #302

Merged
merged 4 commits into from Sep 24, 2021
Merged

Windows support for build_test #302

merged 4 commits into from Sep 24, 2021

Conversation

stdbug
Copy link
Contributor

@stdbug stdbug commented Jun 2, 2021

I have to point out that the approach used in this PR is a bit hacky as it marks .bat file as executable on Windows. AFAIK, in order to spawn processes on Windows, Bazel uses CreateProcessW function whose docs says that caller should use cmd.exe as the application name and the batch file as one of lpCommandLine arguments. On the other hand, I don't know any Windows flavor that wouldn't run the batch file if it's passed as the application name to CreateProcessW

Copy link

@FaBrand FaBrand left a comment

Some suggestions to make the empty test more concise with its runfiles

rules/build_test.bzl Outdated Show resolved Hide resolved
rules/build_test.bzl Outdated Show resolved Hide resolved
rules/build_test.bzl Outdated Show resolved Hide resolved
rules/build_test.bzl Outdated Show resolved Hide resolved
rules/build_test.bzl Show resolved Hide resolved
rules/build_test.bzl Show resolved Hide resolved
@tetromino tetromino requested a review from meteorcloudy Sep 23, 2021
@tetromino tetromino merged commit 14f17ae into bazelbuild:main Sep 24, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants