diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaBinary.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaBinary.java index 0ce7380f2860cc..cc7a91024c3144 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaBinary.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaBinary.java @@ -120,7 +120,7 @@ public ConfiguredTarget create(RuleContext ruleContext) Lists.newArrayList(common.targetsTreatedAsDeps(ClasspathType.COMPILE_ONLY)); helper.addLibrariesToAttributes(deps); attributesBuilder.addNativeLibraries( - collectNativeLibraries(ruleContext, common.targetsTreatedAsDeps(ClasspathType.BOTH))); + collectNativeLibraries(common.targetsTreatedAsDeps(ClasspathType.BOTH))); // deploy_env is valid for java_binary, but not for java_test. if (ruleContext.getRule().isAttrDefined("deploy_env", BuildType.LABEL_LIST)) { @@ -677,9 +677,9 @@ private void collectDefaultRunfiles( * @return the native libraries found in the transitive closure of the deps. */ public static Collection collectNativeLibraries( - RuleContext ruleContext, Iterable deps) { + Iterable deps) { NestedSet linkerInputs = - new NativeLibraryNestedSetBuilder(ruleContext).addJavaTargets(deps).build(); + new NativeLibraryNestedSetBuilder().addJavaTargets(deps).build(); return LibraryToLink.getDynamicLibrariesForLinking(linkerInputs); } diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java index d69235edd8512a..4d6a9ff0a2d175 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java @@ -307,7 +307,7 @@ public static void checkRuntimeDeps( * @see JavaNativeLibraryInfo */ protected NestedSet collectTransitiveJavaNativeLibraries() { - NativeLibraryNestedSetBuilder builder = new NativeLibraryNestedSetBuilder(ruleContext); + NativeLibraryNestedSetBuilder builder = new NativeLibraryNestedSetBuilder(); builder.addJavaTargets(targetsTreatedAsDeps(ClasspathType.BOTH)); if (ruleContext.getRule().isAttrDefined("data", BuildType.LABEL_LIST)) { diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java index eda85581afee1b..a1e8c6b373b1ee 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java @@ -112,7 +112,6 @@ public enum ImportDepsCheckingLevel { private final boolean disallowResourceJars; private final boolean disallowLegacyJavaToolchainFlags; private final boolean experimentalTurbineAnnotationProcessing; - private final boolean dontCollectSoArtifacts; // TODO(dmarting): remove once we have a proper solution for #2539 private final boolean useLegacyBazelJavaTest; @@ -151,7 +150,6 @@ public JavaConfiguration(BuildOptions buildOptions) throws InvalidConfigurationE this.addTestSupportToCompileTimeDeps = javaOptions.addTestSupportToCompileTimeDeps; this.runAndroidLint = javaOptions.runAndroidLint; this.limitAndroidLintToAndroidCompatible = javaOptions.limitAndroidLintToAndroidCompatible; - this.dontCollectSoArtifacts = javaOptions.dontCollectSoArtifacts; ImmutableList.Builder