Fix turbine command lines with empty javacopts

See #4422 PiperOrigin-RevId: 181497117
bazelbuild · Jan 10, 2018 · 22ccdd1 · 22ccdd1
1 parent f6ca788
commit 22ccdd1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java
@@ -549,9 +549,11 @@ private CustomCommandLine.Builder baseCommandLine(
         result.addExecPaths("--source_jars", ImmutableList.copyOf(sourceJars));
       }
 
-      result.addAll("--javacopts", javacOpts);
-      // terminate --javacopts with `--` to support javac flags that start with `--`
-      result.add("--");
+      if (!javacOpts.isEmpty()) {
+        result.addAll("--javacopts", javacOpts);
+        // terminate --javacopts with `--` to support javac flags that start with `--`
+        result.add("--");
+      }
 
       if (ruleKind != null) {
         result.add("--rule_kind", ruleKind);