Make AndroidInstall actions hermetic with respect to dex shards.

They were missing from the inputs, but since the action had the LOCAL execution requirement it ran locally without sandboxing, so this bug could only be triggered by building without the bytes.

Also change the execution requirement to NO_REMOTE, which permits sandboxing and would have caught this issue even when building with the bytes.

Related to #14523.

PiperOrigin-RevId: 533549342
Change-Id: I731f15071e5e08822a298abc5146b91a56ba1071

Author: tjgq

src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinaryMobileInstall.java

@@ -25,6 +25,7 @@
 import com.google.devtools.build.lib.actions.ActionOwner;
 import com.google.devtools.build.lib.actions.Artifact;
 import com.google.devtools.build.lib.actions.CommandLines;
+import com.google.devtools.build.lib.actions.ExecutionRequirements;
 import com.google.devtools.build.lib.actions.ParamFileInfo;
 import com.google.devtools.build.lib.actions.ParameterFile.ParameterFileType;
 import com.google.devtools.build.lib.actions.ResourceSetOrBuilder;
@@ -168,21 +169,23 @@ static void addMobileInstall(
 
     createInstallAction(
         ruleContext,
-        /* incremental = */ false,
+        /* incremental= */ false,
         fullDeployMarker,
         argsArtifact,
         incrementalDexManifest,
+        shardDexZips,
         mobileInstallResourceApks.incrementalResourceApk.getArtifact(),
         incrementalApk,
         nativeLibs,
         stubData);
 
     createInstallAction(
         ruleContext,
-        /* incremental = */ true,
+        /* incremental= */ true,
         incrementalDeployMarker,
         argsArtifact,
         incrementalDexManifest,
+        shardDexZips,
         mobileInstallResourceApks.incrementalResourceApk.getArtifact(),
         incrementalApk,
         nativeLibs,
@@ -381,7 +384,8 @@ private static void createInstallAction(
       boolean incremental,
       Artifact marker,
       Artifact argsArtifact,
-      Artifact dexmanifest,
+      Artifact dexManifest,
+      ImmutableList<Artifact> shardDexZips,
       Artifact resourceApk,
       Artifact apk,
       NativeLibs nativeLibs,
@@ -395,18 +399,19 @@ private static void createInstallAction(
             .setMnemonic("AndroidInstall")
             .setProgressMessage(
                 "Installing %s%s", ruleContext.getLabel(), (incremental ? " incrementally" : ""))
-            .setExecutionInfo(ImmutableMap.of("local", ""))
+            .setExecutionInfo(ImmutableMap.of(ExecutionRequirements.NO_REMOTE, ""))
             .addTool(adb)
             .addOutput(marker)
-            .addInput(dexmanifest)
+            .addInput(dexManifest)
+            .addInputs(shardDexZips)
             .addInput(resourceApk)
             .addInput(stubDataFile)
             .addInput(argsArtifact);
 
     CustomCommandLine.Builder commandLine =
         CustomCommandLine.builder()
             .addExecPath("--output_marker", marker)
-            .addExecPath("--dexmanifest", dexmanifest)
+            .addExecPath("--dexmanifest", dexManifest)
             .addExecPath("--resource_apk", resourceApk)
             .addExecPath("--stub_datafile", stubDataFile)
             .addExecPath("--adb", adb.getExecutable())
@@ -443,7 +448,7 @@ private static void createSplitInstallAction(
             .addTool(adb)
             .setMnemonic("AndroidInstall")
             .setProgressMessage("Installing %s using split apks", ruleContext.getLabel())
-            .setExecutionInfo(ImmutableMap.of("local", ""))
+            .setExecutionInfo(ImmutableMap.of(ExecutionRequirements.NO_REMOTE, ""))
             .addTool(adb)
             .addOutput(marker)
             .addInput(stubDataFile)