Skip to content

Commit 46a36d6

Browse files
aiutocopybara-github
authored andcommitted
Update cquery to useAnalysisProtosV2.
RELNOTES: None PiperOrigin-RevId: 411049390
1 parent 8210f6d commit 46a36d6

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

src/main/java/com/google/devtools/build/lib/query2/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ java_library(
114114
"//src/main/java/net/starlark/java/annot",
115115
"//src/main/java/net/starlark/java/eval",
116116
"//src/main/java/net/starlark/java/syntax",
117-
"//src/main/protobuf:analysis_java_proto",
117+
"//src/main/protobuf:analysis_v2_java_proto",
118118
"//src/main/protobuf:build_java_proto",
119119
"//src/main/protobuf:failure_details_java_proto",
120120
"//third_party:auto_value",

src/main/java/com/google/devtools/build/lib/query2/cquery/ProtoOutputFormatterCallback.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import com.google.common.annotations.VisibleForTesting;
1717
import com.google.common.collect.ImmutableMap;
1818
import com.google.common.collect.Ordering;
19-
import com.google.devtools.build.lib.analysis.AnalysisProtos;
19+
import com.google.devtools.build.lib.analysis.AnalysisProtosV2;
2020
import com.google.devtools.build.lib.analysis.config.ConfigMatchingProvider;
2121
import com.google.devtools.build.lib.cmdline.Label;
2222
import com.google.devtools.build.lib.events.ExtendedEventHandler;
@@ -63,7 +63,7 @@ public String formatName() {
6363
private final SkyframeExecutor skyframeExecutor;
6464
private final JsonFormat.Printer jsonPrinter = JsonFormat.printer();
6565

66-
private AnalysisProtos.CqueryResult.Builder protoResult;
66+
private AnalysisProtosV2.CqueryResult.Builder protoResult;
6767

6868
private KeyedConfiguredTarget currentTarget;
6969

@@ -83,7 +83,7 @@ public String formatName() {
8383

8484
@Override
8585
public void start() {
86-
protoResult = AnalysisProtos.CqueryResult.newBuilder();
86+
protoResult = AnalysisProtosV2.CqueryResult.newBuilder();
8787
}
8888

8989
@Override
@@ -126,7 +126,7 @@ public String getName() {
126126
}
127127

128128
@VisibleForTesting
129-
public AnalysisProtos.CqueryResult getProtoResult() {
129+
public AnalysisProtosV2.CqueryResult getProtoResult() {
130130
return protoResult.build();
131131
}
132132

@@ -136,8 +136,8 @@ public void processOutput(Iterable<KeyedConfiguredTarget> partialResult)
136136
ConfiguredProtoOutputFormatter formatter = new ConfiguredProtoOutputFormatter();
137137
formatter.setOptions(options, resolver, skyframeExecutor.getHashFunction());
138138
for (KeyedConfiguredTarget keyedConfiguredTarget : partialResult) {
139-
AnalysisProtos.ConfiguredTarget.Builder builder =
140-
AnalysisProtos.ConfiguredTarget.newBuilder();
139+
AnalysisProtosV2.ConfiguredTarget.Builder builder =
140+
AnalysisProtosV2.ConfiguredTarget.newBuilder();
141141

142142
// Re: testing. Since this formatter relies on the heavily tested ProtoOutputFormatter class
143143
// for all its work with targets, ProtoOuputFormatterCallbackTest doesn't test any of the
@@ -149,7 +149,7 @@ public void processOutput(Iterable<KeyedConfiguredTarget> partialResult)
149149
if (options.protoIncludeConfigurations) {
150150
String checksum = keyedConfiguredTarget.getConfigurationChecksum();
151151
builder.setConfiguration(
152-
AnalysisProtos.Configuration.newBuilder().setChecksum(String.valueOf(checksum)));
152+
AnalysisProtosV2.Configuration.newBuilder().setChecksum(String.valueOf(checksum)));
153153
}
154154

155155
protoResult.addResults(builder.build());

src/test/java/com/google/devtools/build/lib/query2/cquery/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ java_test(
130130
"//src/main/java/com/google/devtools/build/lib/query2/engine",
131131
"//src/main/java/com/google/devtools/build/lib/query2/query/aspectresolvers",
132132
"//src/main/java/com/google/devtools/build/lib/util:filetype",
133-
"//src/main/protobuf:analysis_java_proto",
133+
"//src/main/protobuf:analysis_v2_java_proto",
134134
"//src/main/protobuf:build_java_proto",
135135
"//src/test/java/com/google/devtools/build/lib/analysis/util",
136136
"//src/test/java/com/google/devtools/build/lib/query2/testutil",

src/test/java/com/google/devtools/build/lib/query2/cquery/ProtoOutputFormatterCallbackTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
import com.google.common.collect.Iterables;
2121
import com.google.common.eventbus.EventBus;
22-
import com.google.devtools.build.lib.analysis.AnalysisProtos;
22+
import com.google.devtools.build.lib.analysis.AnalysisProtosV2;
2323
import com.google.devtools.build.lib.analysis.config.TransitionFactories;
2424
import com.google.devtools.build.lib.analysis.util.MockRule;
2525
import com.google.devtools.build.lib.events.Event;
@@ -91,7 +91,7 @@ public void testSelectInAttribute() throws Exception {
9191
" values = {'foo': 'cat'}",
9292
")");
9393

94-
AnalysisProtos.ConfiguredTarget myRuleProto =
94+
AnalysisProtosV2.ConfiguredTarget myRuleProto =
9595
(Iterables.getOnlyElement(getOutput("//test:my_rule").getResultsList()));
9696
List<Build.Attribute> attributes = myRuleProto.getTarget().getRule().getAttributeList();
9797
for (Build.Attribute attribute : attributes) {
@@ -141,19 +141,19 @@ public void testConfigurationHash() throws Exception {
141141
"simple_rule(name = 'dep')");
142142

143143
// Assert checksum from proto is proper checksum.
144-
AnalysisProtos.ConfiguredTarget myRuleProto =
144+
AnalysisProtosV2.ConfiguredTarget myRuleProto =
145145
Iterables.getOnlyElement(getOutput("//test:my_rule").getResultsList());
146146
KeyedConfiguredTarget myRule = Iterables.getOnlyElement(eval("//test:my_rule"));
147147

148148
assertThat(myRuleProto.getConfiguration().getChecksum())
149149
.isEqualTo(myRule.getConfigurationChecksum());
150150

151151
// Assert checksum for two configured targets in proto are not the same.
152-
List<AnalysisProtos.ConfiguredTarget> protoDeps =
152+
List<AnalysisProtosV2.ConfiguredTarget> protoDeps =
153153
getOutput("deps(//test:my_rule)").getResultsList();
154154
assertThat(protoDeps).hasSize(2);
155155

156-
Iterator<AnalysisProtos.ConfiguredTarget> protoDepsIterator = protoDeps.iterator();
156+
Iterator<AnalysisProtosV2.ConfiguredTarget> protoDepsIterator = protoDeps.iterator();
157157
assertThat(protoDepsIterator.next().getConfiguration().getChecksum())
158158
.isNotEqualTo(protoDepsIterator.next().getConfiguration().getChecksum());
159159
}
@@ -166,7 +166,7 @@ public void testAlias() throws Exception {
166166
"simple_rule(name = 'my_rule')",
167167
"alias(name = 'my_alias', actual = ':my_rule')");
168168

169-
AnalysisProtos.ConfiguredTarget alias =
169+
AnalysisProtosV2.ConfiguredTarget alias =
170170
Iterables.getOnlyElement(getOutput("//test:my_alias").getResultsList());
171171

172172
assertThat(alias.getTarget().getRule().getName()).isEqualTo("//test:my_alias");
@@ -196,7 +196,7 @@ public void testAlias_withSelect() throws Exception {
196196
getHelper().useConfiguration("--foo=woof");
197197
helper.setQuerySettings(Setting.NO_IMPLICIT_DEPS);
198198

199-
List<AnalysisProtos.ConfiguredTarget> myAliasRuleProto =
199+
List<AnalysisProtosV2.ConfiguredTarget> myAliasRuleProto =
200200
getOutput("deps(//test:my_alias_rule)").getResultsList();
201201

202202
List<String> depNames = new ArrayList<>(myAliasRuleProto.size());
@@ -210,7 +210,7 @@ private MockRule getSimpleRule() {
210210
return () -> MockRule.define("simple_rule");
211211
}
212212

213-
private AnalysisProtos.CqueryResult getOutput(String queryExpression) throws Exception {
213+
private AnalysisProtosV2.CqueryResult getOutput(String queryExpression) throws Exception {
214214
QueryExpression expression = QueryParser.parse(queryExpression, getDefaultFunctions());
215215
Set<String> targetPatternSet = new LinkedHashSet<>();
216216
expression.collectTargetPatterns(targetPatternSet);

0 commit comments

Comments
 (0)