Skip to content

Commit 6452024

Browse files
Googlercopybara-github
authored andcommitted
Enable --use_top_level_targets_for_symlinks by default.
RELNOTES: Enable --use_top_level_targets_for_symlinks by default. PiperOrigin-RevId: 454603210 Change-Id: I9bb2f0a46beeff27798b2a6006d5763ae5ff75c7
1 parent 54575fb commit 6452024

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/main/java/com/google/devtools/build/lib/buildtool/BuildRequestOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ public String getSymlinkPrefix(String productName) {
344344
// To be made a no-op and deleted once new symlink behavior is battle-tested.
345345
@Option(
346346
name = "use_top_level_targets_for_symlinks",
347-
defaultValue = "false",
347+
defaultValue = "true",
348348
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
349349
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
350350
help =

src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,6 +726,7 @@ private ImmutableList<ConvenienceSymlink> createConvenienceSymlinks(
726726
// Gather configurations to consider.
727727
Set<BuildConfigurationValue> targetConfigurations =
728728
buildRequestOptions.useTopLevelTargetsForSymlinks()
729+
&& !analysisResult.getTargetsToBuild().isEmpty()
729730
? analysisResult.getTargetsToBuild().stream()
730731
.map(ConfiguredTarget::getActual)
731732
.map(ConfiguredTarget::getConfigurationKey)

0 commit comments

Comments
 (0)