From 9039498faeb338e5d92c14271e4e09f3eb643202 Mon Sep 17 00:00:00 2001 From: Googler Date: Tue, 26 Jul 2022 08:15:58 -0700 Subject: [PATCH] Enable more objc rule attrs to work with --compile_one_dependency These were (inadvertently?) different than the native rules' attributes, which worked with --compile_one_dependency. PiperOrigin-RevId: 463339751 Change-Id: I75d30a899a822a01ba4fb85f2873f9865bedd667 --- src/main/starlark/builtins_bzl/common/objc/attrs.bzl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/starlark/builtins_bzl/common/objc/attrs.bzl b/src/main/starlark/builtins_bzl/common/objc/attrs.bzl index 8fea74c294a1fc..63490490bf7e4d 100644 --- a/src/main/starlark/builtins_bzl/common/objc/attrs.bzl +++ b/src/main/starlark/builtins_bzl/common/objc/attrs.bzl @@ -55,8 +55,12 @@ _COMPILING_RULE = { ), "non_arc_srcs": attr.label_list( allow_files = [".m", ".mm"], + flags = ["DIRECT_COMPILE_TIME_INPUT"], + ), + "pch": attr.label( + allow_single_file = [".pch"], + flags = ["DIRECT_COMPILE_TIME_INPUT"], ), - "pch": attr.label(allow_single_file = [".pch"]), "runtime_deps": attr.label_list( providers = [AppleDynamicFrameworkInfo], flags = ["DIRECT_COMPILE_TIME_INPUT"], @@ -73,9 +77,11 @@ _COMPILING_RULE = { _COMPILE_DEPENDENCY_RULE = { "hdrs": attr.label_list( allow_files = True, + flags = ["DIRECT_COMPILE_TIME_INPUT"], ), "textual_hdrs": attr.label_list( allow_files = True, + flags = ["DIRECT_COMPILE_TIME_INPUT"], ), "includes": attr.string_list(), "sdk_includes": attr.string_list(),